PeculiarVentures / xmldsigjs / 40560991683

86%

push

github

refactor(core): break the xml_object/xml_collection import cycle (#145)

xml_object.ts imported XmlCollection for one `instanceof` check, and
xml_collection.ts extends XmlObject. Whichever module loads first decides
whether `class XmlCollection extends XmlObject` sees XmlObject, and the
generated index of an unbundled build imports xml_object.js first, so
xml-core fails to load ("Class extends value undefined").

XmlCollection.prototype now carries a module-private brand symbol from
const.ts, and xml_object.ts checks the brand and only imports the
XmlCollection type. The check accepts the same objects as before
(XmlCollection and its subclasses).

A spec loads xml_object.js first and covers the noRoot error path.

1119 of 1511 branches covered (74.06%)

3 of 3 new or added lines in 3 files covered. (100.0%)

2276 of 2654 relevant lines covered (85.76%)

2339.59 hits per line