PeculiarVentures / xmldsigjs / 40560472319

86%

push

github

refactor: satisfy strict and noImplicitOverride type checks (#144)

The shared tsconfig enables `strict` (with strictPropertyInitialization
and noImplicitAny, which the old config turned off) and
`noImplicitOverride`. Make the sources pass it:

- add `override` to 94 overriding members
- add definite assignment assertions (`!`) to 176 properties of the
  XmlObject classes; their accessors are installed by the xml-core
  decorators, so nothing assigns them in a constructor
- type the `hash` reads in SignedXml.Sign and X509Certificate instead of
  indexing with a string, and annotate the spec helpers

Type-only changes: the generated .d.ts files are identical, and the
emitted JavaScript only changes `alg["hash"]` to `alg.hash` in those two
places.

1118 of 1511 branches covered (73.99%)

55 of 55 new or added lines in 13 files covered. (100.0%)

2273 of 2652 relevant lines covered (85.71%)

2341.25 hits per line