hyperledger-labs / fabric-smart-client / 40493051143

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(storage): order the KVS primary key by namespace (#2273)

GetStateRangeScanIterator filters the key-value table on one namespace
and a pkey range, but the table's primary key was (pkey, ns), so a scan
read index entries for every namespace in that range. Fresh tables get
PRIMARY KEY (ns, pkey), and CreateSchema reorders an existing (pkey, ns)
key on startup, on Postgres and SQLite.

The key lookup and the reorder move from the two vault drivers into the
Postgres and SQLite storage packages, and the vault and the KVS both
call them. SQLite rebuilds the table from the caller's column
definitions, because the KVS and vault columns differ. On Postgres the
KVS reorder runs before the notifier's trigger is created, and the
reorder needs a user that owns the key-value store table.

postgres.NewKeyValueStore returns *postgres.KeyValueStore instead of
*common.KeyValueStore, and KeyValueStoreNotifier embeds it. Code that
type-asserts the store to *common.KeyValueStore must unwrap it through
the KeyValueStore field. An older node keeps working against a
reordered table, because the upsert's ON CONFLICT (ns, pkey) matches
either column order.

Fixes #2272

Signed-off-by: Ujjwal Khandelwal <ujjwal.khandelwal@yahoo.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

90 of 112 new or added lines in 7 files covered. (80.36%)

4 existing lines in 2 files now uncovered.

30089 of 32919 relevant lines covered (91.4%)

1247.86 hits per line