hyperledger-labs / fabric-smart-client / 40487749515

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(storage): map connection loss on SQL store writes; test(integration): dependency outage specs (#2267)

A Postgres outage longer than committer.retries × committer.retrySleep still stopped a channel's block delivery. While the database was down, committing a block failed on the envelope INSERT. SimpleKeyDataStore.PutData returned the driver's error without passing it through the store's SQLErrorWrapper, so the error never became driver.ErrConnectionLost and the committer classified it as degrade instead of retrying until the database came back. PutData backs the envelope, endorse-tx and metadata stores, which are all on the commit path. PutData and the inserts of the signer-info, audit-info and binding stores now return the wrapped error. TestPut_MapsConnectionLoss checks that each of the four writes returns ErrConnectionLost for a lost connection. The other store tests use a wrapper that passes unrecognized errors through, as a real wrapper does, instead of one that maps every error to nil.

The faultrecovery suites gain the dependency outage specs. On Fabric, bob's delivery peer is restarted; one of three raft orderers is stopped, and then all of them are stopped and started; and a
Postgres outage outlasts a one-second commit retry budget. During that outage commit_retries rises, commit_failures stays flat, delivery stays connected, and the transactions ordered during the outage become final once the database is back. That spec runs in its own Describe, so the shortened budget applies to it alone. In both suites, bob starts while its database is down and becomes ready (GET /readyz) once the database is back. The Fabric-x committer restart spec is pending (#2268): the all-in-one committer container also runs a mock orderer that keeps blocks in memory,
so a transaction ordered after a restart never commits.

The nwo web client gains Ready, which probes GET /readyz. EndorseView returns the transaction with its ID. The shared faultrecovery package ga... (continued)

Coverage Stats

10 of 11 new or added lines in 4 files covered. (90.91%)

4 existing lines in 3 files now uncovered.

30084 of 32912 relevant lines covered (91.41%)

1248.56 hits per line