pmd / pmd / 899

80%

Build Type

push

github

Committed by web-flow

Commit Message

[java] Fix #7146, #7149: Loose invocation conversion and the most specific check for boxing (#7163)

Infer.isConvertible boxed both sides and, when that failed, unboxed
both sides, so int was convertible to Long and null to int. JLS 5.3
allows boxing followed by widening reference conversion and unboxing
followed by widening primitive conversion. The most specific check in
PhaseOverloadSet compared parameter types with the same loose
convertibility and had a special case for boxed parameters. JLS
15.12.2.5 does not use boxing or unboxing for this comparison, so the
check now uses the strict conversion path and the special case is
removed.

A conditional with a null literal and a numeric or boolean branch is
typed as the box of that branch, as javac does, so h(b ? 1 : null)
still resolves to h(int). The branches of a standalone conditional
are checked against their own standalone types.

Coverage Stats

20557 of 26714 branches covered (76.95%)

Branch coverage included in aggregate %.

14 of 15 new or added lines in 3 files covered. (93.33%)

1 existing line in 1 file now uncovered.

43938 of 53911 relevant lines covered (81.5%)

0.82 hits per line