pmd / pmd

80%

push

github

[apex] Fix #7182: Expose the referenced type name on ClassRefExpression (#7201)

A class literal is represented by ASTClassRefExpression, but the node had
an empty Image and no children, so nothing in the tree told an XPath rule
which type the literal referred to. DefiningType only names the enclosing
class and therefore cannot distinguish two literals in the same class.

The referenced type is already present in the Summit AST, so expose it as
the Type attribute. The name follows ASTCastExpression, ASTNewObjectExpression
and ASTParameter, which all expose their type name the same way. Qualified
and nested names are kept (Foo.Bar.class gives Foo.Bar), and because the
value belongs to the literal itself, it is also available when the literal
is passed straight to a method call.

Fixes #7182

20645 of 26756 branches covered (77.16%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

44058 of 53989 relevant lines covered (81.61%)

0.82 hits per line