pmd / pmd / 898

80%

Build Type

push

github

Committed by web-flow

Commit Message

[java] Fix #7150: type of numeric conditionals with byte, short or char operands (#7162)

A conditional like flag ? 'a' : 1 was typed int by binary numeric
promotion. JLS 15.25.2 gives char when one operand is a char and the
other is an int constant that fits, short for byte with short, and the
unboxed type for a Byte, Short or Character operand with such a
constant. getConditionalStandaloneType now applies these rules before
the promotion. Conditionals before Java 8 take the same standalone path
instead of a computation from the branch types alone. On that path a
diamond constructor call is inferred from its arguments instead of
being typed with the generic type declaration. The branches of a
standalone conditional are checked against its type, not against the
parameter type of the enclosing call.

Coverage Stats

20547 of 26706 branches covered (76.94%)

Branch coverage included in aggregate %.

25 of 25 new or added lines in 4 files covered. (100.0%)

4 existing lines in 1 file now uncovered.

43938 of 53911 relevant lines covered (81.5%)

0.82 hits per line