IJHack / QtPass / 40446717617

68%

main: 93%

Build Type

push

github

Committed by web-flow

Commit Message

[1.8] Security scan follow-ups, part 2: copy hints and autoclear for the entry view (#2056)

* [1.8] Security scan follow-ups, part 2: copy hints and autoclear

The rest of #2051 (and #2053) for the 1.8 branch: text copied out of a
shown entry got onto the clipboard as plain text, without the secret
hints, and was not cleared by autoclear.

- SecretTextBrowser (from main) for the field values and the rest of the
  entry: every copy path (Ctrl+C, context menu, drag, primary selection)
  goes through createMimeDataFromSelection() and gets the hints.
- SecretLineEdit (from main, with the fix from #2051's review) for a
  hidden password shown with the eye button: Ctrl+C and Copy are marked,
  and QLineEdit is kept from filling the primary selection with plain
  text at all.
- 1.8 keeps its clipboard logic in QtPass, not a ClipboardManager: a new
  CopiedTexts tracks the copied texts beside clippedText with main's
  rules (a growing selection counts once; a copy still on the clipboard
  is never dropped to make room), and QtPass::trackCopied() feeds it and
  starts the autoclear timer. clearClipboard() clears those too.

Tests in tst_util: main's SecretTextBrowser and SecretLineEdit tests,
and CopiedTexts directly. Offscreen 27 suites, 986 passed; the selection
tests also under X11 (Xvfb), 0 skipped. CHANGELOG: the entry in the
Unreleased 1.8.5 section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* [1.8] SecretLineEdit: find the menu's Copy by its connection, not its name

createSecretContextMenu() looked the standard Copy action up by
objectName() == "edit-copy". Qt names it so only since 6.7 (qtbase
77c6b0c66f); on 5.15 and early 6 nothing matched, so the context menu's
Copy stayed QLineEdit::copy(): plain text, no hints, no autoclear. The
Qt 5.15 CI job failed secretLineEditContextMenuCopyIsMarked() on it.

Tell the... (continued)

Coverage Stats

60 of 86 new or added lines in 6 files covered. (69.77%)

41 existing lines in 4 files now uncovered.

5245 of 7666 relevant lines covered (68.42%)

74.65 hits per line