IJHack / QtPass / 40419139757

68%

main: 93%

push

github

[1.8] Security scan follow-ups, part 1: WSL signing key, decompression limit, templates, OTP seed (#2055)

* [1.8] Security scan follow-ups, part 1: WSL, decompression, templates, OTP

Backport of #2051 for the 1.8 branch (a 1.8.5 to come; no release yet).
1.8's code differs, so this is ported by hand:

- WSL: WSLENV forwards PASSWORD_STORE_SIGNING_KEY to pass in WSL, and
  the length, character set and GPG options get /u; /w meant "from WSL
  out", so pass there never saw them, and without the signing key it
  did not check .gpg-id.sig.
- Decompression: the four gpg decryptions (show, re-encrypt and its
  check, content search) pass --max-output 64 MiB; the pass backend gets
  it through PASSWORD_STORE_GPG_OPTS after the user's own options.
- Templates: .templates and .default_template are read only when they
  are regular files (no link, device or FIFO), and at most 64 KiB, with a
  UTF-8 byte order mark dropped. 1.8 has no Util::openRegularFile, so the
  check is by QFileInfo before the open; the bounded read stops a file
  that is swapped or grows after it.
- otpauth: a bare otpauth:// line is never split into a field, also not
  when the template lists "otpauth".

The copy hints for the entry view (SecretTextBrowser, SecretLineEdit,
tracking for autoclear) follow in a second PR: 1.8 keeps its clipboard
logic in QtPass, not in a ClipboardManager.

CHANGELOG: an Unreleased 1.8.5 section with the security entries and the
WSL upgrade note. Tests for each fix; make check: 27 suites, 981 passed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* CHANGELOG: mark the older Upgrade Notes heading as a deliberate duplicate

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

---------

Signed-off... (continued)

46 of 47 new or added lines in 4 files covered. (97.87%)

5159 of 7518 relevant lines covered (68.62%)

68.44 hits per line