Chia-Network / chia-blockchain / 40342116316

90%

Build Type

push

github

Committed by web-flow

Commit Message

update create_block_generator RPC to use the right fork settings (#21563)

`get_flags_for_height_and_constants()` tells us which features to enable
based on block height (features are specified by the flags).

<!-- CURSOR_SUMMARY -->
> [!NOTE]
> **Low Risk**
> Narrow change to RPC-side simulated block validation flags; does not
alter on-chain consensus paths, but wrong flags could mis-report
validation/cost for the endpoint.
> 
> **Overview**
> The **`/create_block_generator`** RPC still builds a mempool-backed
generator and runs **`run_block_generator2`** to validate it, but
validation no longer passes only **`MEMPOOL_MODE`**.
> 
> It now computes **`flags = MEMPOOL_MODE |
get_flags_for_height_and_constants(curr_l_tb.height,
self.service.constants)`**, using the height of the last transaction
block before the peak so simulated blocks follow the same fork/CLVM
rules as real validation at that tip.
> 
> This imports **`get_flags_for_height_and_constants`** from
**`chia_rs`** for that call.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
5c256b3be. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Coverage Stats

20147 of 25098 branches covered (80.27%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

9 existing lines in 3 files now uncovered.

118640 of 128424 relevant lines covered (92.38%)

1.85 hits per line