Chia-Network / chia-blockchain / 40360634422

91%

Build Type

push

github

Committed by web-flow

Commit Message

[CHIA-4449] Honor consensus constants for V2 plot filters (#21565)

## summary

fixes [CHIA-4449](https://chia-network.atlassian.net/browse/CHIA-4449).

- use `ConsensusConstants.PLOT_FILTER_V2_RELATIVE_HEIGHT` instead of the
duplicated Python schedule, so configured V2 filter reductions take
effect.
- use `FILTER_WINDOW_SIZE` and `MAX_EFFECTIVE_PLOT_FILTER_BITS` from
consensus constants across proof validation, harvesting, simulator
filtering, and challenge selection. iteration compensation consumes the
same configured cap.
- remove obsolete Python constants and add schedule-boundary regression
coverage. default behavior and height semantics are unchanged.

## verification

- 310 focused tests passed during implementation verification, including
additional local window/cap regression tests that are not included in
the current commits.
- focused Ruff lint/format and mypy checks passed; Ruff reports the
existing removed-rule warning for `RUF076`.
- 50,672 default-equivalence comparisons passed during review.
- full repository suite and live farming were not run.

## scope / rollout

non-default constants must agree across network participants. this
intentionally changes overrides that were previously ignored. no new
configuration validation or compensation math is introduced; zero-sized
windows and caps below the active base remain unsupported.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **High Risk**
> Changes consensus plot-filter math and challenge windowing; mismatched
constants between nodes would fork eligibility, and networks that relied
on ignored overrides will now diverge from prior behavior.
> 
> **Overview**
> V2 plot filter behavior now reads
**`PLOT_FILTER_V2_RELATIVE_HEIGHT`**, **`FILTER_WINDOW_SIZE`**, and
**`MAX_EFFECTIVE_PLOT_FILTER_BITS`** from **`ConsensusConstants`**
instead of hard-coded Python values, so non-default schedules and
window/cap overrides actually apply during validation, harvesting,
simulator filtering, and filter-chal... (continued)

Coverage Stats

20113 of 25098 branches covered (80.14%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 5 files covered. (100.0%)

54 existing lines in 23 files now uncovered.

118566 of 128427 relevant lines covered (92.32%)

1.85 hits per line