thumbor / libthumbor / 40150411327

100%

push

github

Fix the Url.generate_options cases that produced broken paths

generate_options formatted its arguments without checking them. A partial
crop printed None (crop_right=10 gave NonexNone:10xNone), a filters list or a
trim tuple, the forms CryptoURL uses, came out as their Python repr, an
invalid halign or valign was appended as is, and adaptive or full without
fit_in vanished. It now reuses the trim, crop, filters and alignment helpers
of get_url_parts: missing crop sides count as zero, sequences and tuples are
rendered like CryptoURL does, and invalid alignments, negative crops and
adaptive or full without fit_in raise ValueError.

A per-option sweep against master changes only the cases above plus trim
strings thumbor cannot read, which now raise. One existing test pinned such
a value (trim="300x200" producing trim:300x200) and now uses
bottom-right:10, which thumbor's regex reads. Url.regex(), which thumbor
routes with, is unchanged, and the eight new tests fail on the previous
commit.

15 of 15 new or added lines in 1 file covered. (100.0%)

370 of 370 relevant lines covered (100.0%)

9.0 hits per line