thumbor / libthumbor / 40146376521

100%

push

github

Validate CryptoURL options instead of signing broken paths

The composer signed whatever it received. String forms produced garbage
(filters="blur(2)" became filters:b:l:u:r:(:2:), trim="top-left" became
trim:t:o), trim=(None, 15) produced trim::15, which thumbor's regex does not
read, flags were plain truthiness so unsafe="false" or smart="false" turned
the option on, and invalid values (width="abc", width=300.0, a negative crop,
an empty image_url, two fit-in variants) were signed into paths thumbor
cannot parse. filters and trim now accept their string forms, trim also its
tolerance alone, flags accept the strings the Django view accepts (the view
now reuses read_flag), digit strings and any numbers.Integral are normalized
to int as dimensions and crop values, so width="0" no longer emits 0x0 and
fit-in with width="0" is rejected, and anything else raises ValueError naming
the option. Falsy trim ("", 0, None) stays ignored, as it was.

Only broken output changes. Over the earlier grid of 2548 option
combinations the sole differences are float dimensions, which produced
segments like 300x300.0 and now raise, and a sweep of each option lists every
other change above. The one existing test that changed pinned trim::15. The
new or changed tests fail on master, and thumbor's 485 handler, composer,
app, config and filter tests pass against this branch.

98 of 98 new or added lines in 3 files covered. (100.0%)

377 of 377 relevant lines covered (100.0%)

9.0 hits per line