thumbor / libthumbor / 40144329099

100%

push

github

Sign CryptoURL paths with the bundled UrlSigner

CryptoURL computed its own base64 HMAC-SHA1 next to UrlSigner, the signer
thumbor imports from libthumbor to validate requests, and the two had already
drifted once: CryptoURL encoded str keys as latin-1 until six was removed.
CryptoURL now holds a UrlSigner and signs the composed path with it, so the
client and the server share one implementation. The key attribute keeps the
same bytes; the precomputed hmac attribute, which nothing in this repository
or in thumbor reads, is gone.

Across 80 combinations of str, non-ASCII, bytes and empty keys, image URLs
and options, master and this branch produce identical URLs. Creating the HMAC
on each call, as UrlSigner does, costs about 0.4 us per generate (3.4 to 3.8
us in a timeit run). CryptoURL(None) used to raise TypeError from hmac.new in
the constructor; UrlSigner stored any key and only failed on the first
signature, so BaseUrlSigner now rejects keys that are not str, bytes or
bytearray at construction, keeping that fail-fast for CryptoURL and giving it
to thumbor as well.

6 of 6 new or added lines in 2 files covered. (100.0%)

339 of 339 relevant lines covered (100.0%)

9.0 hits per line