thumbor / libthumbor / 40143795223

100%

push

github

Let projects validate requests before the Django view signs them

The view signs any image_url and options it can parse, and the README could
only tell users to put it behind authentication; nothing let a project
restrict hosts or filters without rewriting the view. The optional
THUMBOR_URL_VALIDATOR setting now names a callable, or its dotted path, that
receives the request and the parsed options before signing. Raising
InvalidParameter answers 400 with its message and raising PermissionDenied
answers 403; a path that does not import, or a value that is not callable,
raises ImproperlyConfigured, as a missing THUMBOR_SECURITY_KEY does. Without
the setting nothing changes.

The README example lives in the test project and the tests drive it, both
through the client (an anonymous request gets 403) and through the view
resolved from the URL with a signed-in user, so the documented code is the
tested code. The example guards urlsplit, which raises ValueError on a
malformed IPv6 host and would otherwise turn into a 500; the README says any
exception other than InvalidParameter and PermissionDenied propagates.
Removing the validator call fails four tests, and the view tests pass on
Django 5.2.18 and 6.1.2.

14 of 14 new or added lines in 1 file covered. (100.0%)

343 of 343 relevant lines covered (100.0%)

9.0 hits per line