solidjs / solid / 39925229618

79%

main: 89%

push

github

fix(compiler): validate SSR templates for malformed HTML (#4238)

The `validate` option only checked DOM templates, so markup that only
ever compiles for the server (JSX inside "use server" functions) was
never validated: `<p>a<div>b</div></p>` compiled cleanly under
`generate: "ssr"` while the DOM compile threw.

SSR templates now rebuild the DOM validator's input from their parts:
tags keep only their names (attribute and hydration-key holes drop with
the attributes), content holes join as nothing, raw-text/RCDATA
contents are copied verbatim, and static `innerHTML` markup is skipped,
as the DOM writes it as a property. An `<html>` root with content holes
is skipped, since a hole there may render the `<head>`/`<body>`. A
mismatch raises the same compile error with line:col.


Claude-Session: https://claude.ai/code/session_01DHFhvcRyES2P8WAJqbLrp2

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

771 of 1066 branches covered (72.33%)

Branch coverage included in aggregate %.

1114 of 1358 relevant lines covered (82.03%)

27.61 hits per line