solidjs / solid / 39917372230

79%

main: 89%

push

github

fix(signals): events dispatched from an effect callback start outside its dev windows (#4237)

* fix(signals): events dispatched from an effect callback start outside its dev windows (#4235)

A DOM call that dispatches synchronously (el.focus(), el.click(),
dialog.showModal()) from an effect's apply half ran its handlers while the
effect's strict-read label and effect-callback phase were still set, so a
prop read in the handler logged STRICT_READ_UNTRACKED and a root created
there threw PRIMITIVE_IN_EFFECT_CALLBACK. Both windows now record the DOM
event current when they open (globalThis.event) and apply only while that
same event is current. Dev-only; production bytes unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* perf(signals): read the dispatching event once per effect queue (#4235)

The first cut read `globalThis.event` at every strict-read window open
(each effect run, labeled untrack, named map row) and every unlabeled
untrack. Under jsdom that getter is costly and CodSpeed showed up to -41%
on dev-mode update benches.

Now only a queued effect run records the event, read once per effect
queue in runQueue (no event starts or ends between two effects of one
synchronous queue). Other windows record ANY_EVENT and behave as before.
Production output is unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

---------

Co-authored-by: Claude <noreply@anthropic.com>

771 of 1066 branches covered (72.33%)

Branch coverage included in aggregate %.

1114 of 1358 relevant lines covered (82.03%)

27.56 hits per line