synackd / ochami / 39871599861

93%

push

github

fix(cmd): honor boolean flags passed as false (#213)

* fix(smd): honor --all=false in delete commands

The smd compep, component, iface, and rfe delete commands decided
whether --all was set by checking whether the flag was passed at all
(cmd.Flag("all").Changed), not by reading its value. Passing
--all=false therefore acted like --all: the command ignored the given
IDs and sent the delete-everything request, e.g.

  ochami smd component delete --no-confirm --all=false x0c0s0b0n0

sent DELETE /State/Components instead of
DELETE /State/Components/x0c0s0b0n0. The PreRunE check had the same
flaw, so --all=false with no IDs passed validation.

Read --all by value in both PreRunE and RunE so --all=false behaves as
if the flag were omitted. Add regression tests asserting that
--all=false with an ID deletes exactly that resource's path, and that
--all=false with no selector is a usage error.

Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>

* fix(cmd): read status flags by value

The smd, bss, pcs, and cloud-init status commands chose which endpoint
to query by checking whether each boolean flag was passed at all
(cmd.Flag(...).Changed), not by reading its value. Passing a flag
explicitly as false therefore acted as if it were true:

  - smd status --all=false queried /service/values
  - bss status --all=false, --storage=false, --smd=false, and the
    deprecated --version=false queried that flag's endpoint
  - pcs service status --all=false (and --storage, --smd, --vault)
    queried /health and reported that flag's fields
  - cloud-init service status --api=false printed the OpenAPI spec,
    and --quiet=false suppressed output

Read each flag with GetBool so that --flag=false behaves the same as
omitting it. Add a table test asserting that each false flag queries
the same endpoints as the bare command, a PCS test asserting that
health flags set to false are left out of the output, and a cloud-init
test asserting that --quiet=fal... (continued)

62 of 62 new or added lines in 13 files covered. (100.0%)

12957 of 13991 relevant lines covered (92.61%)

553.11 hits per line