synackd / ochami / 39982817304

93%

push

github

fix(metadata): confirm deletion before resolving client and token (#214)

The metadata defaults, group, instance, and peer delete commands created
the metadata service client and handled the access token before asking
"Really delete?". Without a base URI or token they failed with an
unrelated error instead of prompting, unlike the other delete commands.

Prompt first, then create the client and handle the token, the same
order as the boot, bss, cloud-init, and smd delete commands. Add the four
commands to TestDeleteConfirm_DeclineBeforeClient.

Fixes #188

Signed-off-by: anyingiit <49945850+anyingiit@users.noreply.github.com>

26 of 32 new or added lines in 4 files covered. (81.25%)

12957 of 13991 relevant lines covered (92.61%)

555.01 hits per line