synackd / ochami / 39818539257

93%

push

github

fix(log): emit real JSON for the json format (#207)

The "json" log format was built on a zerolog ConsoleWriter, which
renders human-readable text. As a result, --log-format json produced
console output (with the ConsoleWriter's default 3:04PM timestamps and
no caller) instead of JSON, contradicting the documented behavior.

Build the logger for the "json" format on the raw writer so zerolog
emits one JSON object per line. ConsoleWriter is still used for the
rfc3339 and basic formats. --log-color is validated as before but has
no effect on JSON output, since JSON is never colorized; document this
in the ochami(1) and ochami-config(5) man pages and the example config.

Add a test that logs in JSON mode and unmarshals the output, checking
the level and message fields and that no ANSI color codes are present.

Signed-off-by: bfs2021 <101915083+bfs2021@users.noreply.github.com>

1 of 1 new or added line in 1 file covered. (100.0%)

12938 of 13976 relevant lines covered (92.57%)

541.13 hits per line