astronomer / astro-cli / 39864586933

61%

main: 45%

push

github

Name APC service accounts with --name, as Astro's API tokens are named (#2420)

* Name APC service accounts with --name, as Astro's API tokens are named

astro workspace service-account create and astro deployment
service-account create take the account's name as --name, -n, with 1.x's
--label, -l, as its hidden alias. They were the last APC commands to show
--label: Astro names its API tokens, its nearest equivalent, with --name.
-n was free on both, so nothing changes meaning.

Co-Authored-By: Claude <noreply@anthropic.com>

* Refuse a service account named "", and test the short spellings disagreeing

From review. service-account create took --name "", or --label "$UNSET"
handed on to it, as given, and created an account with no name and a live
API key; it is a usage error now, as workspace create refuses a workspace
with none. TestWorkspaceSaCreate named none and passed on a name an earlier
test left behind; it names its own.

The examples name the account ci-deployer rather than my_label, and the
test covers -n and -l agreeing and disagreeing.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

16 of 16 new or added lines in 2 files covered. (100.0%)

41682 of 68693 relevant lines covered (60.68%)

411.56 hits per line