astronomer / astro-cli / 39861367836

61%

main: 45%

push

github

Spell APC deployment create/update's label --name, and adopt's custom resource --cr-name (#2418)

* Spell APC deployment create and update's label --name, and adopt's custom resource --cr-name

astro deployment create and update on APC take --name, as Astro's do and
as APC's workspace commands now do, with no shorthand: -n is 1.x's
--nfs-location there. 1.x's --label/-l keeps working as its hidden alias.

astro deployment adopt's 1.x --name is the custom resource's
metadata.name, so it cannot become the Deployment's name: the custom
resource's is --cr-name, with --name its hidden alias, still meaning the
custom resource, and the adopted Deployment's name keeps --label. adopt is
behind a version gate the 1.x flag inventory did not pass, so its --name
is on the hidden-flag allowlist with that reason.

Co-Authored-By: Claude <noreply@anthropic.com>

* Give APC deployment create and update's --name -n, as Astro's has, and refuse an NFS location as the name

-n on APC's deployment create and update is now --name, as on Astro and
on APC's workspace commands. 1.x's -n there was --nfs-location, which
keeps its long spelling and has no shorthand now.

A 1.x line passing the mount as -n would otherwise name the Deployment
after it, on update silently. A --name shaped as an NFS location,
<host>:/<path>, is a usage error naming --nfs-location; on create, 1.x's
required --label beside it already makes the two disagree.

Co-Authored-By: Claude <noreply@anthropic.com>

* Refuse an NFS location given to --name as the line is parsed, so a 1.x -l beside it does not hide why

From review. The check ran in create's and update's RunE, after 1.x's
--label had been reconciled with --name, so the usual 1.x create line,
-l prod -n 10.0.0.5:/dags, was refused as the two disagreeing, with
advice to keep the mount as the name. --name is now a flag value that
refuses an NFS location as it is set, ahead of that reconciliation, on
both commands, through one helper that also registe... (continued)

51 of 53 new or added lines in 2 files covered. (96.23%)

41672 of 68683 relevant lines covered (60.67%)

410.98 hits per line