decentraland / atlas-server / 39792801841

94%

push

github

chore: drop unused deps and tighten the docker image and ci config (#150)

## What changed

- Removes `decentraland-transactions` (never imported; it pulled ~1000
transitive packages: web3 connectors, squid, cosmjs).
- Removes `ethers` v5: its only use was comparing rental prices in
`legacy-tiles.ts`. That is now a `BigInt` comparison that accepts
exactly the inputs `BigNumber.from` accepted. 200k randomized
comparisons (including malformed values) found no difference, and the
new table test passes against both implementations.
- `npm update` within the existing ranges.
- `.dockerignore` skips `.git`, `docs`, `coverage` and `.env*` but keeps
`.env.defaults`. `tests` stays because the build stage runs them.
- `npm ci --omit=dev` replaces the deprecated `--only=production`.
- Adds `--max-semi-space-size=16` to the node flags. Measured on Node 24
with the 38 MB prd map, RSS goes from ~448 to ~390 MiB.
- Deletes the dead `.gitlab-ci.yml` (it references a `.ci` dir that no
longer exists).
- `.nvmrc` is now 24 and the node.yml step label now says Node 24.x.
- `publish-docs.yml` scopes the `GITBOOK_*` secrets to the publish step
and pins `@redocly/cli@2.58.2` and `@gitbook/cli@0.32.8`.

## npm audit

Before: 105 findings (13 critical, 30 high, 53 moderate, 9 low).

After: 41 findings (0 critical, 36 high, 5 moderate), from 4 remaining
advisories:
- braces/micromatch in jest 29 (dev)
- semver in nodemon 2 (dev)
- sprintf-js (dev)
- glob CLI in node-pg-migrate via `@dcl/pg-component` (no fix available)

`npm audit --omit=dev` reports only the glob chain.

## Verification

`tsc`, the full jest suite and prettier on the changed files pass.
`redocly lint` passes with the pinned version. The Docker image
(`--platform linux/amd64`, from a clean export) builds, runs its tests
in the build stage, and starts.

523 of 670 branches covered (78.06%)

Branch coverage included in aggregate %.

24 of 29 new or added lines in 1 file covered. (82.76%)

2166 of 4207 relevant lines covered (51.49%)

17.89 hits per line