decentraland / atlas-server / 39789475306

55%

master: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix: start the map in the background and drop stale cached prices and districts (#146)

## Cause
- interfaces 1.5 starts components one after another, and `map.start()`
awaited the whole first load plus a `sleep(REFRESH_INTERVAL)`, so the
HTTP server port stayed closed for minutes. A failed first load rejected
`tiles` and never polled again.
- The S3 cache is reused as is and `addSpecialTiles` only adds missing
ids, so the `district` tiles removed in #142 survive every restart.
- Trade prices have no `expiresAt`, so `expireOrders` never clears them
and the S3 cache carries them across restarts (prd shows parcels/estates
for sale that the marketplace doesn't list).

## Fix
- `start()` kicks off the load without awaiting it; a failed load is
retried every `REFRESH_INTERVAL`. Futures are resolved once, when the
load succeeds (same moment `ready` flips). `stop()` ends the retry/poll
loops.
- The cache is discarded and fresh data fetched when a cached tile's
special type disagrees with `specialTiles.json`
(`hasStaleSpecialTiles`).
- Each trades pass first clears trade-derived prices (price without
`expiresAt`; order prices always carry one) and then applies the active
trades. `getActiveTrades` rethrows, so a DB failure skips the pass and
keeps the previous prices.

## Verification
- New `map.spec.ts` / `map-utils.spec.ts`, updated `trades.spec.ts`;
`jest` 89/89, `tsc` clean.

Coverage Stats

512 of 670 branches covered (76.42%)

Branch coverage included in aggregate %.

296 of 326 new or added lines in 4 files covered. (90.8%)

4 existing lines in 1 file now uncovered.

2140 of 4180 relevant lines covered (51.2%)

17.6 hits per line