decentraland / atlas-server / 39798590350

94%

push

github

test: cover rendering, s3 and the http wiring (#148)

## What was wrong

`src/components.ts`, `service.ts`, the router/handlers, `render/*` and
the S3 component had no tests (51% of lines covered), and there was no
way to exercise a request through the real middleware chain (CORS,
Last-Modified, status checks).

## What changed

- `tests/harness/`: `startTestServer()` boots the app through
`initComponents` + `main` under `Lifecycle.run` (as `src/index.ts`) on a
random port. Subgraph, pg, S3, traced fetch and feature flags are
stubbed via `jest.mock` (all `jest.fn`, re-programmable per test); the
map is either the real component or `createFixtureMap()` serving
in-memory tiles/NFTs. `server.fetch(path)` uses native fetch. App log
lines are silenced unless `verbose: true`.
- Route tests (`tests/http/`): `/health/{live,ready,startup}` and
`/v2/ready` (503 while the real map has not loaded), `/v2/ping`,
`/v2/tiles/info`, `/v1|v2/tiles` (non-redirect, area and `include`
filters, legacy shape), parcels/estates/contracts tokens incl. dissolved
estates, districts, map PNGs, CORS `*` on GET without Origin / 404 /
preflight / thrown 500, Last-Modified and If-Modified-Since → 304.
- Unit tests: viewport math, tile/map rendering (geometry and pixel
colors on a real canvas), S3 keys/URLs and upload→read round trips
against an in-memory bucket, legacy type codes, metric registration.
- `jest.config.js`: global coverage threshold (80/75/80/80) a few points
under the new level.

No production code changes.

## Verification

`tsc --noEmit`, prettier and the full jest suite (193 tests) pass.
Coverage on master → this branch: lines 51.3% → 86.5%, branches 78.1% →
81.5%, functions 65% → 85.7%.

## Deliberately left out

Behaviour that open fix PRs change: on-sale/rent edges, estatemap
encoding, PNG size bounds, id parsing, `exclude` filter, tiles under
redirect, cache headers on token responses and cache-wrapper growth.
Those PRs can add route tests on this harness.

845 of 1020 branches covered (82.84%)

Branch coverage included in aggregate %.

3659 of 4201 relevant lines covered (87.1%)

55.06 hits per line