Qiskit / qiskit-fermions / 39768952521

98%

main: 98%

Build Type

push

github

Committed by web-flow

Commit Message

fix(circuit): reject non-positive Suzuki-Trotter orders (#393) (#394)

The order check only ruled out odd values, so 0 and negative even orders
passed the constructor. The recursion in the schedule builder only stops
at orders 1 and 2, so any such order descended forever and surfaced as a
RecursionError at synthesis time, far from the offending argument. An
operator with a single factor short-circuits before the recursion, so
whether it failed also depended on the operator.

Validate in the constructor instead: the order must be 1 or a positive
even integer.


(cherry picked from commit 95e1e9d9b)

Co-authored-by: Max Rossmannek <21973473+mrossinek@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

13950 of 14205 relevant lines covered (98.2%)

460128.92 hits per line