Qiskit / qiskit-fermions
98%

DEFAULT BRANCH: main
Repo Added
Files 104
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 98.046% (+0.03%) from 98.021%
33368664568

push

github

web-flow 
Use exact FCI traces for matrix exponentials (#279)

* Use exact FCI traces for matrix exponentials

* Update releasenotes/notes/exact-fci-trace-9d950da5d3abe256.yaml

* refactor: read the exact FCI trace from the kernel, not a patched attribute

The exact-trace change plumbed the trace to the matrix-exponential callers by
patching a private `_trace` attribute onto the SciPy `LinearOperator` returned by
`_linear_operator_`. That coupled a *public* protocol's return value to metadata
only this package's wrapper sets: `SupportsLinearOperator` promises nothing more
than a `scipy.sparse.linalg.LinearOperator`, so any other conforming operator
reaching `Evolution` raised `AttributeError` on the read. The `isinstance`
FermionOperator guard hid that today, but the comment above it records the intent
to remove the guard once `SupportsLinearOperator` folds into `OperatorTrait` --
at which point the crash goes live.

A SciPy `LinearOperator` is also simply the wrong carrier: it has nowhere to put
the value, and composing one drops any attached attribute (`scale * linop`
returns a bare `_ScaledLinearOperator`), so the metadata survived exactly one hop
by luck.

The trace does not need transporting at all. The internal
`_fci_linear_operator_` carrier already returns the native `FciLinearOperator`,
which exposes `trace` as a real, typed, documented getter next to the
matrix-vector action. Going through that carrier gives both pieces from one
object, so the private attribute, both `cast(Any, ...)` escapes and a stale
`type: ignore` all disappear, and the public wrapper goes back to returning an
unadorned operator.

This keeps the numerical win intact: still 82x faster and ~63000x more accurate
than `traceA=0.0` on a large-trace operator, measured against a dense `expm`
reference. Behaviour is unchanged -- the trace handed to SciPy is bit-identical.

The shared helper now takes the operator rather than a prebuilt operator/trace
pair, which also confines the FCI-kern... (continued)

113 of 113 new or added lines in 5 files covered. (100.0%)

12191 of 12434 relevant lines covered (98.05%)

523805.41 hits per line

Relevant lines Covered
12434 RELEVANT LINES 12191 COVERED LINES
523805.41 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
33368664568 main Use exact FCI traces for matrix exponentials (#279) * Use exact FCI traces for matrix exponentials * Update releasenotes/notes/exact-fci-trace-9d950da5d3abe256.yaml * refactor: read the exact FCI trace from the kernel, not a patched attribute ... push web-flow github
98.05
33368010229 fix/exact-expm-trace Merge d50967cfc into cd27fcf1e Pull #279 web-flow github
98.05
33096227836 fix/exact-expm-trace Merge 46fa4d129 into cd27fcf1e Pull #279 web-flow github
98.05
33017076694 memory-jw Merge de8c1c4a1 into cd27fcf1e Pull #297 web-flow github
98.05
33014860605 memory-jw Merge 48a5c1e3a into cd27fcf1e Pull #297 web-flow github
98.05
32980911712 stable/0.1 docs: restructure the guides overview page (#295) (#296) * docs: restructure the guides overview page * docs: promote "workflow validation" section level (cherry picked from commit cd27fcf1e) Co-authored-by: Max ... push web-flow github
98.02
32979888878 mergify/bp/stable/0.1/pr-295 Merge bb4440b0c into 86d2e13e1 Pull #296 web-flow github
98.02
32979863509 main docs: restructure the guides overview page (#295) * docs: restructure the guides overview page * docs: promote "workflow validation" section level push web-flow github
98.02
32978715709 update-guides-overview Merge 6b1ffb650 into 7c96ed62b Pull #295 web-flow github
98.02
32977098172 update-guides-overview Merge 824ae83bf into 7c96ed62b Pull #295 web-flow github
98.02
See All Builds (564)