immerjs / immer / 39553225342

47%

push

github

fix: resolve the splice start index against the pre-splice length in array-methods plugin (#1315)

The plugin normalised the start index after calling copy_.splice, so for
a negative start or a start past the end it used the post-splice length.
handleInsertedValues then registered the inserted values at the wrong index,
and a value containing a draft (e.g. {copy: draft.items[0]}) was left
pointing at a revoked proxy after finalization.

Capture the length before splicing and use that.

684 of 733 branches covered (93.32%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1769 of 4542 relevant lines covered (38.95%)

2091.56 hits per line