immerjs / immer / 39554072861

47%

push

github

fix: draft relocated base objects at previously assigned indices in array-methods plugin (#1314)

isRelocatedBaseRef (added in #1255) bails out when assigned_ has an entry for
the index. But push, unshift, splice and index writes leave such entries
behind, and after a later reverse/sort/unshift they describe an index, not the
value that now sits there. A base object relocated onto one of those indices
was returned from the get trap undrafted, so writing to it mutated the base
state (and threw on a frozen base).

baseRefs_ already identifies relocated base objects, and objects the user
newly assigned are never in it, so the assigned_ check is not needed.

684 of 733 branches covered (93.32%)

Branch coverage included in aggregate %.

1768 of 4541 relevant lines covered (38.93%)

2174.95 hits per line