immerjs / immer / 39446464170

47%

push

github

fix: skip nested patches for children of shifted or reordered arrays (#1316)

With enableArrayMethods(), unshift/shift/splice/reverse/sort run natively on
copy_ and mark all indices as reassigned. A child drafted afterwards gets its
key from the index it now sits at, so getPath accepts it and emits a nested
patch such as ["arr", 3, "a"]. That patch is generated before the parent
array's own patches. When the index is past the base length (e.g. unshift and
then writing to the last element) it points at a path that does not exist yet,
and applyPatches throws "path doesn't resolve".

The array already emits a replace/add patch for every index that changed,
carrying the finalized child, so nested patches add nothing there. Return no
path for children of an array whose indices were reassigned. This also matches
the patches produced without the plugin, where such children are not patched
individually either.

684 of 733 branches covered (93.32%)

Branch coverage included in aggregate %.

5 of 6 new or added lines in 1 file covered. (83.33%)

1771 of 4544 relevant lines covered (38.97%)

2043.48 hits per line