kubeflow / mcp-server / 39469259660
87%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 38
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.419%. Remained the same
39469259660

push

github

web-flow 
chore(docs): define the mutation authorization and safety model (#424)

* chore(docs): define the mutation authorization and safety model

Mutating tools had their safety rules spread across CONVENTIONS.md, policy.py,
security.py and each tool, so a new tool could easily miss one.

Add docs/design/mutation-safety.md, which lists every mutating tool with its
persona, namespace, ownership and preview behavior, the order the checks run
in, the rules a new mutating tool must follow, and the gaps found while
checking the code (the preview-then-confirm order is not enforced,
patch_runtime is not marked destructive, runtime previews use ToolResponse,
audit entries in dynamic modes name execute_tool, persona state is global).
Link it from CONVENTIONS.md.

Fixes #311

Signed-off-by: pratik naik <naikp0241@gmail.com>

* chore(docs): scope fail-closed to authorization checks and link #433

Review feedback on #424:
- Only the authorization checks (exposure, namespace, ownership) fail closed.
  Add a best-effort checks section for the delete_runtime dependency check,
  which treats a failed TrainJob listing as no dependents and still deletes on
  confirmed=True (#340 fixes only the preview), and list it as a gap.
- Link #433 for deciding how to enforce preview before a confirmed destructive
  call, which needs a decision and owner for v0.2.

Signed-off-by: pratik naik <naikp0241@gmail.com>

* chore(docs): mark the check order as intended and qualify the preview

Review feedback on #424:
- The order of checks is the intended one, not what every tool does today:
  fine_tune() checks namespace policy before validating its other inputs. Say
  so, and list it as a gap.
- A preview only means the checks passed when it was generated; RBAC, an
  admission policy or a changed resource can still refuse the confirmed call.

Signed-off-by: pratik naik <naikp0241@gmail.com>

---------

Signed-off-by: pratik naik <naikp0241@gmail.com>

2724 of 3189 relevant lines covered (85.42%)

2.56 hits per line

Jobs
ID Job ID Ran Files Coverage
1 python-3.12 - 39469259660.1 38
85.42
GitHub Action Run
2 python-3.11 - 39469259660.2 38
85.42
GitHub Action Run
3 python-3.10 - 39469259660.3 38
85.42
GitHub Action Run
Source Files on build 39469259660