astronomer / astro-cli / 39447145560

61%

main: 45%

push

github

Read -d on astro af and astro api airflow as a link, a Deployment id, or a Deployment name (#2387)

* Read astro af -d as an id or a name when no link has it

A -d value no link declares was always sent to GET by id, so a Deployment
name 404'd. It now reads the way --deployment reads on astro deployment and
astro deploy: a link name is the link, a Deployment id (util.IsCUID) is that
Deployment, fetched across the organization with no extra call, and anything
else is a Deployment name, looked up in --workspace, else the project's
[tool.astro] workspace, else the workspace of the login the project's links
use. None, or several (listed by id), is an error; inside a project a name
that matched nothing leads with the project's links, the likelier typo.

astro af gains --workspace (v2 spelling only: af did not exist in 1.x) so a
name can be looked up outside the default workspace. With an id it has to
contain the Deployment, checked off the lookup the address needs anyway; with
a link it has to agree with the link's workspace; it cannot apply to an MWAA,
Composer or url link, nor be combined with --url, nor be empty.

The name lookup lives in internal/instancelocate, which already does the af
Deployment lookup: NamedDeployment and DeploymentNameError are exported so
astro api airflow (which imports the package) can share them, and the
locator implements a new optional DeploymentFinder seam that cmd/local asks
for. No pkg/* sub-module changes.

Co-Authored-By: Claude <noreply@anthropic.com>

* Pin --workspace on an id end to end, paging, and apc links

Review follow-ups for astro af -d by name:

- a Deployment id given with --workspace is refused end to end when it is in
  another workspace, pinning that findDeployment carries the flag for ids as
  well as names;
- the name lookup reads every page of a workspace's listing, and a name
  shared across pages is ambiguous;
- an apc link is held to --workspace like an Astro link (its own Houston
  workspace), not... (continued)

203 of 236 new or added lines in 6 files covered. (86.02%)

41294 of 68284 relevant lines covered (60.47%)

394.2 hits per line