astronomer / astro-cli / 39360245809

61%

main: 45%

Build Type

push

github

Committed by web-flow

Commit Message

Read --deployment and --workspace, with the 1.x spellings as aliases (#2378)

* Read --deployment and --workspace, with the 1.x spellings as aliases

Commands read the v2 flags now. --deployment-id, --deployment-name and
--workspace-id are hidden aliases, keeping 1.x's -d, -n and team add's -w,
that utils.ApplyAliases hands to the flag they stand for, refusing a
disagreement as before. --deployment knows the command's id and name and
splits once (deploymentFlag.resolve, routeDeployment's rule); an alias
keeps the kind it was typed as, so a non-CUID --deployment-id is still an
id and -d with -n is still both. followProject, create --clone and setup
read the v2 flags. The env link commands keep their own --deployment-id,
which still shadows the noun's scope flag.

An archlint test fails on a 1.x spelling named outside the alias helpers.
Nothing user-visible changes.

Co-Authored-By: Claude <noreply@anthropic.com>

* Check 1.x spellings by constant value, and drop setup's dead dev branch

The archlint guard now type-checks cmd/ and internal/ and fails on any
expression whose constant value is a 1.x spelling, so a named constant
or a concatenation is caught where it is used. Allowed: arguments to
utils.AddAlias, and named functions and tables rather than whole files.
AddAlias returns its flag, so addDeploymentFlag looks nothing up by name.

Setup's astro dev branch is unreachable: a removed command's stub never
reaches the platform pre-run. It and workspaceOrDeploymentIDFlagSet go.

Co-Authored-By: Claude <noreply@anthropic.com>

* Keep the 1.x spelling guard a plain literal scan

Revert the type-checked version: the guard catches an honest copy of the
old pattern, not deliberate evasion, so a scan of string literals under
cmd/ with a short file allowlist is enough. golang.org/x/tools goes back
to indirect.

The context cmd case of TestSetup relied on the deleted dev cases leaving
the login stubbed; it stubs it itself now.

Co-Authored-By: Claude <noreply... (continued)

Coverage Stats

192 of 203 new or added lines in 18 files covered. (94.58%)

5 existing lines in 1 file now uncovered.

41111 of 68086 relevant lines covered (60.38%)

394.08 hits per line