astronomer / astro-cli / 39464190922

61%

main: 45%

Build Type

push

github

Committed by web-flow

Commit Message

Give --workspace only to the deployment commands that read it (#2391)

* Give --workspace only to the deployment commands that read it

astro deployment registered --workspace (and 1.x's --workspace-id) on the
whole group, so team, user and most token commands showed a flag they never
read, and passing it still made followProject skip the project's workspace
and host. It is now on the commands that read it: list, create (and
--clone), update, delete, logs, inspect, hibernate, wake-up, the variable,
worker-queue and bundle commands, and token workspace-token add and remove.
The rest keep 1.x's --workspace-id, hidden and read by nothing, which
chooses no workspace.

On APC the group's --workspace-id moves to create, list and adopt. The
other commands 1.x had keep it as a hidden no-op; hibernate and wake-up,
newer than 1.x, take none.

Bugs fixed on the way:
- deployment list --all, on both platforms, found the workspace before
  reading --all, so it failed with no workspace to find (an org token).
- APC's coalesceWorkspace read the context before --workspace-id, so a
  context with no workspace failed a command that named one.
- token workspace-token add and remove read the raw flag, so the
  project's workspace was ignored; they go through coalesceWorkspace.
- workspace team list takes --workspace like its siblings, and it and
  workspace user list show the role on the current workspace, which they
  compared with "" and left blank.

Co-Authored-By: Claude <noreply@anthropic.com>

* Say what replaced --workspace on deployment team, user and token

They took a --workspace in v2 until the previous commit, and now answer it
with cobra's bare "unknown flag". A v2Only removed-flag entry tells such a
run that these commands act on the Deployment it names, which carries its
workspace; 1.x's --workspace-id stays a no-op, workspace-token add and
remove still take --workspace, and APC's commands of these names, which
never had one, keep cobra's error.

Also pin ... (continued)

Coverage Stats

83 of 105 new or added lines in 11 files covered. (79.05%)

3 existing lines in 1 file now uncovered.

41376 of 68352 relevant lines covered (60.53%)

399.32 hits per line