39245973170
90%

Ran 19 Oct 2026 11:43AM UTC

Jobs 0

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 39245973170

Build Type

push

github

Committed by

web-flow

Commit Message

[sidecar testing] Fix a data race in TestSidecarStartWithoutCoordinator (#849)

#### Type of change

- Bug fix
- Test update

#### Description

- `newSidecarTestEnvWithTLS` handed the sidecar a pointer to the mock
coordinator's own server-config endpoint
(`&coordinatorServer.Configs[0].GRPC.Endpoint`).
- `TestSidecarStartWithoutCoordinator` restarts the coordinator from
that same config. `ServerConfig.Listener` then rewrites `Endpoint.Port`
while the sidecar's `Run` reads the endpoint to log it and dial the
coordinator. Nothing synchronizes the two, so under `-race` the test
fails with `WARNING: DATA RACE`, and so does every test running in
parallel with it.
- The sidecar now gets its own copy of the endpoint. The restart rebinds
the same port, so the copy stays correct.

#### Additional details (Optional)

The race window is a few milliseconds, so it shows up only
intermittently on CI. To reproduce it locally, add `time.Sleep(500 *
time.Millisecond)` right after `s.ready.SignalReady()` in `Service.Run`
(`service/sidecar/sidecar.go`) and run:

go test -race -count=10 -run 'TestSidecarStartWithoutCoordinator$'
./service/sidecar/

Without this fix, 4 of 10 runs failed with the race. With it, 0 of 10
failed.

Signed-off-by: Dean Amar <Dean.Amar@ibm.com>

Coverage Stats

Source Files on build 39245973170

Detailed source file information is not available for this build.

hyperledger / fabric-x-committer / 39245973170
90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on build 39245973170

hyperledger / fabric-x-committer / 39245973170 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on build 39245973170

hyperledger / fabric-x-committer / 39245973170
90%

README BADGES
x