coreui / coreui-pro / 39146212673

96%

main: 94%

push

github

refactor: keep the selection of a list and its owner in one store (#1685)

The selection of a combobox-like component lived in two places: the component's own model and the list box it renders, kept in step by projecting the model onto the list (`ListBox._setSelection`, `ComboboxBase._projectSelection`) and, in MultiSelect, by reconciling what the list proposed against what the model held. Combobox, Autocomplete and MultiSelect now create one selection store (`createSelectionStore` in `util/selection-state`) and hand it to their list box. The list writes the gestures the user makes, the component writes everything else through `_commitSelection`, and the list redraws only when the component changed the store. The projection, the reconciliation and their helpers are gone.

Public events keep their order and payload (`select` cancelable, write, `selected` per value, one `change`). A value the owner's rule refuses gets no `selected`. Labels and locks of selected values the list no longer carries stay in a separate snapshot, and the form reset target keeps its own labels, so later options do not relabel it.

A list given its owner's store still adds the items marked `selected` to it, so a Combobox built from `items` starts with them. While MultiSelect loads, it refuses a selection by canceling the list's `select` and `deselect` events instead of undoing it afterwards. The list itself keeps accepting selection while loading, as before, which Transfer relies on when it clears a loading side.

7705 of 8261 branches covered (93.27%)

Branch coverage included in aggregate %.

131 of 131 new or added lines in 6 files covered. (100.0%)

13272 of 13561 relevant lines covered (97.87%)

1980.24 hits per line