solidjs / solid / 38788470174

78%

main: 89%

push

github

fix(signals): createRoot's dispose function no longer retains init (#4095) (#4097)

* fix(signals): createRoot's dispose function no longer retains init (#4095)

The dispose function passed to init was created inside createRoot's
scope, which also holds init, so keeping the dispose function kept init
and everything it closes over alive. Build it in a helper instead.

Also fix test:gc's include, which matched no files under the suite's
`dir: "./tests"` setting, so the gc tests never ran.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fTNh1FgQx2WTF5xoxwML1

* fix(signals): bind createRoot's dispose instead of a helper closure

A bound disposeRootSelf holds only the owner, like the helper did, and
is smaller than the original arrow (-2 B minified vs next instead of
+18 B).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fTNh1FgQx2WTF5xoxwML1

---------

Co-authored-by: Claude <noreply@anthropic.com>

751 of 1042 branches covered (72.07%)

Branch coverage included in aggregate %.

1086 of 1328 relevant lines covered (81.78%)

27.89 hits per line