astronomer / astro-cli / 38599781424

60%

main: 45%

Build Type

push

github

Committed by web-flow

Commit Message

Write command names as plain text in CLI output (#2294)

* Render backticked command names in terminal output

Messages, help and errors name a command the way the docs do, in
backticks, and terminals printed the backticks literally. The source keeps
them; the output layer now renders them: bold on a terminal with color on,
plain text anywhere else (a pipe, a file, NO_COLOR), and plain text in the
--output json error object and warning records.

The rule is narrow (pkg/ansi/backticks.go): a pair of backticks on one line
around up to 200 characters that do not start or end with a space, with no
letter or digit outside either backtick. A lone backtick, an empty pair, a
run of three, and one inside a word or a quoted value are left as they are.

Co-Authored-By: Claude <noreply@anthropic.com>

* Revert "Render backticked command names in terminal output"

This reverts commit f3acec63. Review found the runtime transform unsafe: a % inside a span went through aurora's Sprintf, real backticks in passed-through uv, HTTP and Airflow text were stripped, and copy-paste commands were rewritten. Command names are written as plain text at the source instead, in the commits that follow.

Co-Authored-By: Claude <noreply@anthropic.com>

* Write command names as plain text in CLI output

Messages, help and notes named commands, flags and paths the way the docs
do, in backticks, and a terminal printed the backticks as they were, as did
an error object's json. They are plain text now, at the source: "astro dev
start was removed in Astro CLI v2. Use astro local start instead." Where a
bare command read ambiguously mid-sentence, the sentence is rephrased
rather than quoted.

TestMessagesWriteCommandsAsPlainText (internal/archlint) fails on a string
literal holding a backtick anywhere in the repo's non-test Go code, except
what its backtickAllowed list names: the markdown astro init writes, the
upgrade prompt handed to Otto, and one shell-metacharacter set.
TestHelpHasNoBac... (continued)

Coverage Stats

115 of 126 new or added lines in 53 files covered. (91.27%)

1 existing line in 1 file now uncovered.

40181 of 69398 relevant lines covered (57.9%)

276.27 hits per line