astronomer / astro-cli / 38619067121

61%

main: 45%

Build Type

push

github

Committed by web-flow

Commit Message

Generate Cosmos Boost sidecars into the deploy bundle, not the project, and retire astro dbt cleanup (#2311)

* Generate Cosmos Boost sidecars into the deploy bundle, not the project, and retire astro dbt cleanup

The pre-deploy step produces its .astro/dbt_metadata.json and
.astro/manifest.slim.json in memory, and the bundle tarball carries
them at the same paths with the same bytes, through a TarOverlay on
fileutil.Tar. Nothing is written into the user's tree.

Every bundle deploy leaves out the sidecars an earlier CLI wrote into
the tree (producer marker "astro"), enabled or not, so a stale one
never ships. One from an unrecognized producer still stops an enabled
deploy, and ships untouched when the step is off.

With nothing left to clean, astro dbt cleanup becomes a removed-command
stub, and its cleanup code, json shape and golden go.

Co-Authored-By: Claude <noreply@anthropic.com>

* Leave old Cosmos Boost sidecars out inside the tarball's walk, and out of generated images

The bundle judges each .astro/dbt_metadata.json and manifest.slim.json
by its producer marker inside Tar's own walk (TarOverlay.Skip), rather
than in a separate pre-scan: what it leaves out is exactly what the
tarball would have carried (one under logs/ too), and a deploy with the
step off never fails over Cosmos Boost - a missing dags/ makes the
empty tarball it always did. A foreign file still refuses an enabled
deploy, now even where a fresh sidecar would replace it.

The predicate lives in pkg/airflowrt, a leaf both the root module and
pkg/imagebuild already require. A generated image's project copy (and
its survey and tag digest) leaves the same files out; a declared
Dockerfile's context carrying them is warned about, naming them.

Tar names entries with filepath.Rel, so a source of "." (astro dbt
deploy --project-path .) names .astro/ and other dotfiles right. A
directory or link where a sidecar goes fails that unit instead of
colliding with it in the bundle. The dbt cl... (continued)

Coverage Stats

223 of 244 new or added lines in 10 files covered. (91.39%)

4 existing lines in 3 files now uncovered.

40132 of 69361 relevant lines covered (57.86%)

276.34 hits per line