astronomer / astro-cli / 38593917777

58%

main: 45%

Build Type

push

github

Committed by web-flow

Commit Message

Deploy only pyproject.toml projects in v2 (#2295)

* Deploy only pyproject.toml projects in v2

v2 deploys only projects with a pyproject.toml, on Astro and on Astro
Private Cloud. Astro CLI 1.x keeps deploying the projects it made, so v2
drops the 1.x deploy rather than carrying it.

Astro: astro deploy in a 1.x-layout project (a Dockerfile beside .astro,
or a .astro/config.yaml) fails with no_project, saying to convert it with
astro init or deploy it with Astro CLI 1.x. Outside any project it gives
the no-project advice, now also no_project. --non-dags runs first, from
anywhere: it deploys a separate directory, and from a pyproject.toml
project it no longer runs a whole project deploy instead.

APC: v2 builds no project. A deploy without --image-name is refused as a
usage error saying to use Astro CLI 1.x (and, from a pyproject.toml
project, that support is coming). --image-name (and --remote) deploy
from anywhere but a 1.x project; --dags uploads a pyproject.toml
project's dags/. Any deploy from a 1.x project is refused.

The 1.x deploy is deleted with its tests: deploy.Deploy and its build,
pytest and parse steps, the named DAG bundle create, APC's Dockerfile
build, airflow's DAGChecker and ImageHandler.Pytest, and what deadcode
found behind them. The flags only it read are removed and tombstoned in
the removed-flags registry: --save, --pytest, --env, --test, --parse,
--deployment-name, --dags-path and --dag-bundle-name on Astro, --save and
--no-cache on APC.

From #2290: config.IsHomeDir in IsProjectDir, the home-directory advice,
and the bound-value --image-name check.

Co-Authored-By: Claude <noreply@anthropic.com>

* Deploy an image from anywhere, and one rule for what a project is

From review of the first commit:

- astro deploy --image-name runs from any directory again, a 1.x project's
  included: it reads nothing from the project. Outside a pyproject.toml
  project it ships the image alone (no dags/), to an id named by the
  argument or -... (continued)

Coverage Stats

400 of 443 new or added lines in 14 files covered. (90.29%)

18 existing lines in 5 files now uncovered.

40180 of 69398 relevant lines covered (57.9%)

255.49 hits per line