decentraland / lamb2 / 38585724641

76%

push

github

fix: return on-chain item amounts as numbers (#487)

* fix: return on-chain item amounts as numbers

The marketplace API serializes amount, minTransferredAt and
maxTransferredAt of grouped wearables and emotes as numeric strings,
and the adapter passed them through, so /explorer/:address/wearables
and /explorer/:address/emotes answered "amount": "1" although Item
types it as a number.

Convert the three fields with Number() when mapping grouped items.

* fix: return item transfer bounds as numbers on every path

The subgraph sends transferredAt as a string, so single-token items from
the fallback (and normalizeWearableFormat) kept min/maxTransferredAt as
strings while multi-token items were coerced by Math.min/max.

Convert through toFiniteNumber, which falls back when a value is missing
or not numeric: amount to the number of tokens, timestamps to 0, which
sorting already treats as no date. Previously these became NaN or 0.

Cover the unpaginated marketplace path, missing fields and the fallback.

* fix: keep the real oldest transfer date of partly undated items

An undated token (0) pulled a grouped item's minTransferredAt down to 0;
the earliest date now ignores undated tokens. Removes the unused
normalizeWearableFormat, and the new fixtures use second timestamps as
production does.

665 of 1041 branches covered (63.88%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 3 files covered. (100.0%)

2017 of 2551 relevant lines covered (79.07%)

81.55 hits per line