decentraland / lamb2 / 38585450012

76%

push

github

fix: type name and order prices as wei strings (#488)

* fix: type name and order prices as wei strings

Name prices come from the marketplace API and the subgraph as wei
strings (e.g. "800815000000000000000000"), and the names endpoint already
answers strings, but Name.price, the marketplace and subgraph name types,
and docs/openapi.yaml declared numbers. Converting them would lose
precision, so the types and OpenAPI now say string. Also documents
individualData transferredAt and price as the strings they are.

The response does not change.

* fix: drop the unused item price type and use wei strings in name mocks

MarketplaceApiBaseData.price was never read (individual prices come from individualData) and contradicted the string price types. The subgraph name mock now uses a wei string like the real data.

653 of 1031 branches covered (63.34%)

Branch coverage included in aggregate %.

2009 of 2547 relevant lines covered (78.88%)

80.77 hits per line