coreui / coreui-pro / 38583834353

96%

main: 94%

push

github

refactor(ListBox, Combobox, MultiSelect): share the selection limit and value list (#1647)

util/selection-state gains toSelectionValues, getSelectionLimit and
isSelectionLimitReached. ListBox and Combobox take the value list from
toSelectionValues, ListBox and MultiSelect the limit from getSelectionLimit and
isSelectionLimitReached, instead of their own copies; the React and Vue
editions import them from @coreui/coreui-pro/utils/selection-state next.

Combobox setValue(undefined) now clears the selection, as setValue(null) does;
it used to select an option whose value is the text "undefined".

7707 of 8284 branches covered (93.03%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 4 files covered. (100.0%)

13371 of 13669 relevant lines covered (97.82%)

1713.83 hits per line