coreui / coreui-pro / 38536243560

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(Carousel): don't leave focus on a disabled control (#1645)

With `ends: 'stop'`, a focused control that gets disabled hands focus to
the opposite control, or to the viewport when there is none. Two gaps let
focus stay on the disabled button, or drop to the page:

- `_refreshActiveState` disabled prev before it re-enabled next, so in a
  two-slide carousel going back to the first slide tried to focus a
  still-disabled next. It now enables before it disables.
- When nothing took focus, the control kept it in browsers that hold
  focus on a disabled button (Firefox does until the next frame; Chromium
  drops it at once; measured with Playwright, WebKit not). The control is
  now blurred when the hand-off did not move focus.

The specs cover the two-slide hand-off, the viewport fallback with a
`tabindex`, and spy on `blur`, since Chromium drops the focus on its own.
The ends section of the docs says where focus goes.

Coverage Stats

7719 of 8297 branches covered (93.03%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

13367 of 13665 relevant lines covered (97.82%)

1713.08 hits per line