astronomer / astro-cli / 38502854607

61%

main: 45%

push

github

Keep the local proxy on 6563 when an astro 1.x proxy holds it, and stop it faster (#2310)

* Stop waiting half a second for a daemon that has already exited

waitForExit slept a full stopPollWait before it first looked, so stopping a daemon cost at least 500ms however fast it exited. A host that stops the daemon on the way out of a project (Astro Desktop removing its last route) paid that on every project stop. It now looks before it sleeps and then every 25ms, with the same stopTimeout deadline and the same forced kill after it.

Co-Authored-By: Claude <noreply@anthropic.com>

* Take the port from an astro 1.x proxy whichever tool starts the daemon

The takeover of a 1.x proxy holding 6563 lived in the CLI and ran as its BeforeStart. A host that starts the shared daemon without it, Astro Desktop, let a 1.x proxy push the daemon to a fallback port, and every tool after it adopted that daemon there, so the CLI's takeover never ran and hostnames stayed off 6563 for as long as the 1.x proxy did.

It is now the daemon's own step in pkg/proxy, run by EnsureRunning before every start, so it applies whichever tool starts the daemon and needs no wiring. It still stops a process only when that process is provably a 1.x proxy serving this daemon's own route store on the port: the one process the daemon is about to replace, whose projects keep their URLs. BeforeStart, which existed only for it, is removed. The 1.x process listing (sysctl on darwin, /proc on linux) moves with it; Windows still does nothing. The stop reuses the daemon's own wait, SIGTERM then the forced kill after stopTimeout.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

40138 of 69463 relevant lines covered (57.78%)

234.86 hits per line