astronomer / astro-cli / 38498144568
61%
main: 45%

LAST BUILD BRANCH: v2-build-on-locked-runtime
DEFAULT BRANCH: main
Ran
Jobs 1
Files 333
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 57.836%. Remained the same
38498144568

push

github

web-flow 
Generic start hint on the local proxy's pages, and collect a stopped daemon (#2309)

* Name both tools on the proxy's pages, and drop Proxy.Running

One daemon now serves projects started from Astro Desktop and from astro local start, so the pages' hint for starting a project names both rather than only the CLI command, which read oddly to someone who has never opened a terminal.

Proxy.Running had one caller, Astro Desktop's in-process proxy, which the desktop no longer runs. Its field went with it.

Co-Authored-By: Claude <noreply@anthropic.com>

* Collect a stopped proxy daemon in the process that started it

The starter released the daemon instead of waiting for it. A starter that outlives its daemon is its parent until it exits, and on unix an unwaited child that exits stays a zombie, which IsPIDAlive's signal 0 still reports alive. So when Astro Desktop, which starts the daemon and runs for hours, stopped it, Stop sat out the whole 5s stopTimeout, then SIGKILLed the corpse, and every start and stop left one more <defunct> process. The CLI never saw it: its process exits right after the start and init collects the orphan.

The starter now waits for the daemon in the background. On Windows the wait holds the process handle until the daemon exits and then closes it, where Release closed it at once. The test binary's re-exec helper moves out of the Windows-only tests so unix tests can start a real daemon too.

Co-Authored-By: Claude <noreply@anthropic.com>

* Keep the proxy's start hint generic

The hint now says to start a project and offers astro local start as one way, rather than naming another product. The daemon serves projects whichever tool started them, so the command reads as an example for anyone. The new comments describe a long-running host rather than a particular one.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

40242 of 69579 relevant lines covered (57.84%)

234.6 hits per line

Jobs
ID Job ID Ran Files Coverage
1 38498144568.1 333
57.84
GitHub Action Run
Source Files on build 38498144568