astronomer / astro-cli / 38579275172

61%

main: 45%

push

github

Run every root-module package's unit tests on Windows (#2297)

* Run every root-module package's unit tests on Windows

The test-windows job's unit-test step ran under the default pwsh shell,
which splits a native argument at a dot: -test.v reached go as -test .v.
go test took the unknown -test as the end of the package list, so it
tested only the root package, which has no Windows test files, and
passed. Every other root-module package went untested on Windows.

Run it under bash like the neighbouring steps, drop -test.v, and fail
the step unless every package go list names reported a result line.

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix the root-module tests that fail on Windows, and file:///C:/ spec URLs

The first Windows run of these packages found one code bug and a set of
tests that assumed Unix.

Code: ResolveLocalPath turned file:///C:/spec.json into /C:/spec.json,
which filepath.Abs then put under the current drive. It now drops the
slash before a drive letter.

Tests: paths and error text spelled the Unix way (separators, otto.exe,
the .exe.zip download, "no such file or directory"), tar entry names
built with filepath.Join though Tar writes them slash-separated, a
directory named "..." that Windows strips to nothing, a launcher test
that read a symlink where Windows makes a copy, and a cwd helper that
expanded the 8.3 short name DetectAirflow compares against. The git-sync
fixtures under cmd/apc/testfiles are pinned to LF, and the two tests that
rely on POSIX mode bits skip on Windows.

Co-Authored-By: Claude <noreply@anthropic.com>

* Satisfy gci and gocritic on the two reworded test comments

Co-Authored-By: Claude <noreply@anthropic.com>

* Name the packages the Windows unit-test step did not report

Compare the set of packages go list names against the set with a result
line, not their counts, and print the missing ones in the error. The
pattern now matches the module path exactly, followed by / or
whitespace, and an empt... (continued)

10 of 14 new or added lines in 2 files covered. (71.43%)

40144 of 69473 relevant lines covered (57.78%)

234.83 hits per line