aio-libs / multidict / 38453354148

86%

push

github

Merge the compact entry matchers of the lock-free lookup (#1794)

<!-- Thank you for your contribution! -->

## What do these changes do?

`_compact_entry_matches_cs()` and `_compact_entry_matches_ci()`, the
entry match of the FT lock-free lookup, differed only in the key
accessors they called. They are replaced by one
`_COMPACT_ENTRY_MATCHES()` macro, expanded directly in
`_md_lockfree_find_cs()` and `_md_lockfree_find_ci()`. Their two rules
in `tools/check_inlining.py` go with them, since a macro cannot be left
out of line.

The code is FT-only; the GIL build and the pure-Python backend are
unaffected.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, a refactor covered by the
existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` passed on 3.14.7t FT with the C extension (4255
passed). `tools/codegen_diff.py` against master 9a1927bc reports 0
functions differing on 3.11.13 and 3.14.7 GIL, so the GIL legs were not
rerun.
Inlining: `tools/check_inlining.py` ok on 3.14.7 and 3.14.7t.
Docs: `make doc-spelling` passed.

Callgrind, `benchmarks/callgrind_driver.py --include-multidict-only`,
3.14.7t, against master 9a1927bc. 52 of 62 FT rows are bit-identical;
the rest:

| build | row | impl | master | this PR | delta |
| --- | --- | --- | ---: | ---: | ---: |
| FT | `key in d` | MultiDict | 176.6 | 175.6 | -0.57% |
| FT | `d.get(key)`, miss | MultiDict | 392.4 | 390.8 | -0.41% |
| FT | `d.get(key)`, miss | CIMulti... (continued)

842 of 1684 branches covered (50.0%)

Branch coverage included in aggregate %.

9799 of 10709 relevant lines covered (91.5%)

1.83 hits per line