aio-libs / multidict / 38453259224

86%

push

github

Share the key/default parsing in the C extension (#1793)

<!-- Thank you for your contribution! -->

## What do these changes do?

`getall()`, `getone()`, `get()`, `setdefault()`, `popone()`, `pop()` and
`popall()` each spelled out the same `parse2()` call for their `(key,
default)` arguments, and four of them the same "return the default or
raise `KeyError`" tail. Both move into helpers in `_multidict.c`:
`_multidict_parse_key_default()` and `_multidict_default_or_raise()`.
GCC inlines both everywhere.

The pure-Python backend has no equivalent and is unaffected.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, a refactor covered by the
existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` passed with the C extension on 3.11.13 GIL (4274
passed) and 3.14.7t FT (4255 passed), and on 3.11.13 pure Python with
`MULTIDICT_NO_EXTENSIONS=1 --no-c-extensions` (1697 passed).
Inlining: `tools/check_inlining.py` ok on 3.14.7 and 3.14.7t.
Docs: `make doc-spelling` passed.

Callgrind, `benchmarks/callgrind_driver.py --include-multidict-only`,
3.14.7 and 3.14.7t, against master 9a1927bc. 59 of 62 GIL and 61 of 62
FT rows are bit-identical; the rest:

| build | row | impl | master | this PR | delta |
| --- | --- | --- | ---: | ---: | ---: |
| GIL | `d[key]` | MultiDict | 158.0 | 153.8 | -2.66% |
| GIL | `d.getall(key)` | MultiDict | 749.8 | 745.5 | -0.57% |
| GIL | `d.get(key)`, miss | MultiDict | 332.1 | 332.7 | +0.18% |... (continued)

842 of 1684 branches covered (50.0%)

Branch coverage included in aggregate %.

9799 of 10709 relevant lines covered (91.5%)

1.83 hits per line