aio-libs / multidict / 38414116879

86%

push

github

Split more C extension helpers per table kind (#1792)

<!-- Thank you for your contribution! -->

## What do these changes do?

Continues #1789: helpers called from loops that already run one per
table kind no longer take the kind and test it again.

- `_md_pop_all_matched()`, `_md_replace_matched()` and
`_md_update_matched()` lose their kind argument. The kind-specific step
(the delete, or the key store) moves into each loop, and what is left is
shared: `_md_pop_all_record()`, `_md_replace_matched()` with
`_md_replace_key_compact()` / `_md_replace_key_anystr()`, and
`_md_update_mark()` / `_md_update_store()`.
- `_md_unlink_at()`, `_md_has_equal_hashes()` and
`_md_publish_compacted()` are split into a compact and an anystr
variant. `_md_pop_one_locked()` calls its own per branch; `popitem()`,
`md_del_at_deferred()` and `_md_rebuild()` pick one by kind once.
- The lookup loops of del, pop, popall, replace, update, merge and
`md_walk_with_hash()` share one nested layout: `if (compact) { if (ci)
... else ... } else ...`.

The `_md_unlink_at` rule in `tools/check_inlining.py` now names both new
helpers. The pure-Python backend has no equivalent and is unaffected.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, a refactor covered by the
existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` passed on 3.14.7 GIL (4270 passed) and 3.14.7t FT
(4255 passed) with the C extension; on 3.11.13 with cibuildwheel's
marker ... (continued)

842 of 1684 branches covered (50.0%)

Branch coverage included in aggregate %.

9799 of 10709 relevant lines covered (91.5%)

1.83 hits per line